Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aliases update on rules_haskell side. #10

Open
kczulko opened this issue Nov 29, 2021 · 3 comments
Open

Aliases update on rules_haskell side. #10

kczulko opened this issue Nov 29, 2021 · 3 comments

Comments

@kczulko
Copy link
Contributor

kczulko commented Nov 29, 2021

Describe the bug

I think that this change tweag/rules_haskell#1636 can introduce problems on gazelle_cabal side.

To Reproduce

Use latest rules_haskell (at least those version which contains #1636) together with gazelle_cabal.

References to repository dependencies may contain leading colons, e.g. @stackage//:base instead of @stackage//base

Expected behavior

@stackage//base instead of @stackage//:base

Environment

  • OS name + version:
  • Version of the code:

Additional context

It should be simple adjustment of rel method

func rel(lbl label.Label, from label.Label) label.Label {

@aherrmann
Copy link
Member

Not objecting to this, but just to clarify.@stackage//:base should still work. Did you encounter issues with this?

@kczulko
Copy link
Contributor Author

kczulko commented Nov 29, 2021

@aherrmann
No I didn't check that and thanks for the clarification! I thought that it might be like that (rules_haskell preserves compatibility). I'll check it.

@kczulko
Copy link
Contributor Author

kczulko commented Oct 19, 2022

Looks like with cabal 3.8.1.0 we have some kind of a "full" support for public sublibraries.

Till now it's a work-in-progress on the hackage side but let me refer to its handler here: haskell/hackage-server#1119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants