Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support file renames / additions / deletions in --watch mode #186

Closed
Bouke opened this issue Apr 14, 2018 · 3 comments
Closed

Support file renames / additions / deletions in --watch mode #186

Bouke opened this issue Apr 14, 2018 · 3 comments
Labels
bug build Ideas for or bugs with the build process

Comments

@Bouke
Copy link
Contributor

Bouke commented Apr 14, 2018

Building on Windows is... well slow. So we mostly run ember build with the --watch option. However in this mode, file renames / additions / deletions of typescript files are not being picked up, and we need to restart ember build. It would be very nice if this package would handle situations like these.

@chriskrycho
Copy link
Member

@Bouke totally agreed (though in my experience it’s more that sometimes they’re picked up, which is even more frustrating!). I’m curious: can you try the WIP branch we have for invoking TS’s watch mode more carefully (PR #172) and see if it handles renames better? I think it may but I haven’t had looked at that specifically yet. Either way, can you please report the results on #172? That’d be super helpful.

@dfreeman
Copy link
Member

Additions, and the adding part of renames, should work out of the box with #172, but tsc --watch doesn't currently clean up emitted files when the source is removed, unfortunately. Once #172 lands, we can probably layer on our own handling for that.

@chriskrycho chriskrycho added bug build Ideas for or bugs with the build process labels Jul 6, 2018
@chriskrycho
Copy link
Member

I believe this was largely resolved by ember-cli-typescript v2 (many years ago now!), and while there are intermittent cache issues with Broccoli, they are are outside the remit of this project to resolve and we recommend people switch to using ember-cli-babel in apps and Rollup plugins in add-ons for building and glint for type checking regardless. Closing as “done”!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug build Ideas for or bugs with the build process
Projects
None yet
Development

No branches or pull requests

3 participants