Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0: Update django.db.backends.base.features.BaseDatabaseFeature #2099

Merged
merged 2 commits into from
May 2, 2024

Conversation

JaeHyuckSa
Copy link
Contributor

@JaeHyuckSa JaeHyuckSa commented Apr 30, 2024

I have made things!

Update stubs for django.db.backends.base.features.BaseDatabaseFeature for Django 5.0.

This list is the added arguments.

  • django.db.backends.base.features.BaseDatabaseFeature
    • django.db.backends.base.features.BaseDatabaseFeatures.delete_can_self_reference_subquery
    • django.db.backends.base.features.BaseDatabaseFeatures.insert_test_table_with_defaults
    • django.db.backends.base.features.BaseDatabaseFeatures.supports_default_keyword_in_bulk_insert
    • django.db.backends.base.features.BaseDatabaseFeatures.supports_default_keyword_in_insert
    • django.db.backends.base.features.BaseDatabaseFeatures.supports_expression_defaults
    • django.db.backends.base.features.BaseDatabaseFeatures.supports_nulls_distinct_unique_constraints
    • django.db.backends.base.features.BaseDatabaseFeatures.supports_stored_generated_columns
    • django.db.backends.base.features.BaseDatabaseFeatures.supports_virtual_generated_columns

This list is the removed arguments.

  • django.db.backends.base.features.BaseDatabaseFeatures.supports_atomic_references_rename

Related issues

Refs

Upstream PR

django.db.backends.base.features.BaseDatabaseFeatures.supports_stored_generated_columns
django.db.backends.base.features.BaseDatabaseFeatures.supports_virtual_generated_columns

django.db.backends.base.features.BaseDatabaseFeatures.supports_nulls_distinct_unique_constraints

django.db.backends.base.features.BaseDatabaseFeatures.delete_can_self_reference_subquery

django.db.backends.base.features.BaseDatabaseFeatures.insert_test_table_with_defaults
django.db.backends.base.features.BaseDatabaseFeatures.supports_expression_defaults
django.db.backends.base.features.BaseDatabaseFeatures.supports_default_keyword_in_insert
django.db.backends.base.features.BaseDatabaseFeatures.supports_default_keyword_in_bulk_insert

django.db.backends.base.features.BaseDatabaseFeatures.supports_atomic_references_rename

@sudosubin sudosubin mentioned this pull request Apr 30, 2024
39 tasks
@sudosubin
Copy link
Contributor

sudosubin commented Apr 30, 2024

Thanks. I think you missed a change.

  • django.db.backends.base.features.BaseDatabaseFeatures.supports_atomic_references_rename was removed

@JaeHyuckSa
Copy link
Contributor Author

JaeHyuckSa commented Apr 30, 2024

Thanks. I think you missed a change.

  • django.db.backends.base.features.BaseDatabaseFeatures.supports_atomic_references_rename was removed

I only saw and worked on the allowtodo so I missed that part. Thanks for the good point :)

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn sobolevn merged commit b97efba into typeddjango:master May 2, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants