Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 5.1.0 release #2374

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

richardebeling
Copy link
Contributor

@richardebeling richardebeling commented Sep 17, 2024

Blindly following the instructions in Contributing.md. pre-commit passes, stubtest passes, I hope that means that this PR makes sense and there are no release blockers.

Version 5.0.4 broke with with Django 5.1 in one of the projects I'm working on due to the check/condition rename that was fixed in #2331 but not yet released.

Copy link
Member

@flaeppe flaeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm suspecting that releasing at this point will result in quite a bit of reports regarding annotate/alias

I've been meaning to dig in to some of the more "normal" usage but haven't gotten around to it yet

Perhaps it's for the better to just release and see what happens

@sobolevn
Copy link
Member

a bit of reports regarding annotate/alias

Sorry, I am out of context. What is this about?

@flaeppe
Copy link
Member

flaeppe commented Sep 18, 2024

I might be misremembering, but I think I had some additional case that would be good to cover in our tests for annotate. Think I had encountered some simple usage that was breaking.

But I have to check if I wrote anything down or if it was from somewhere else

@richardebeling
Copy link
Contributor Author

@flaeppe any updates on release blockers?

@flaeppe
Copy link
Member

flaeppe commented Sep 23, 2024

Sorry, I meant to comment here that I think it was along the lines of what #2376 resolved. So I don't have any blockers.

@flaeppe flaeppe merged commit 931b5b2 into typeddjango:master Sep 23, 2024
36 checks passed
@flaeppe
Copy link
Member

flaeppe commented Sep 23, 2024

New versions released just now:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants