Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with upcoming munit v1 #147

Closed
armanbilge opened this issue Oct 16, 2021 · 5 comments · Fixed by #223
Closed

Integrate with upcoming munit v1 #147

armanbilge opened this issue Oct 16, 2021 · 5 comments · Fixed by #223

Comments

@armanbilge
Copy link
Member

Opening the issue to kick things off, munit v1 is still in the milestone stage.
https://github.com/scalameta/munit/releases/tag/v1.0.0-M1

The most notable changes (so far) are that it now supports async suite-local Fixtures 🎉 . Much gratitude to @danicheg for PRing this 👏

My biggest question is: for how long do we still intend to support both CE2 and CE3? Since we are bumping version numbers anyway, I'd be happy to use this opportunity to dump CE2 and the acrobatics this repo uses to share code between them.

@mpilquist
Copy link
Member

I think we should support munit 1 + ce2 as there are a lot of projects (fs2 2.5.x included) that depend on munit and we shouldn't strand them on a 0.x release.

@armanbilge
Copy link
Member Author

@mpilquist 6 months later, do you still feel the same?

We will shortly be removing http4s 0.22.x from Steward. Meanwhile, I discovered the other day that fs2 2.5.x CI probably hasn't worked for months.

@valencik had the excellent suggestion to look at download stats. Here they are for the CE2 and CE3 versions, don't be fooled by the colors! :)

The majority of the CE2 users have not updated since 1.0.0, which suggests those projects are not actively maintained. Meanwhile, the majority of the CE3 users are on the latest release.

chart

chart-1

@mpilquist
Copy link
Member

No strong opinions here.

@otto-dev
Copy link

otto-dev commented Apr 30, 2022

FYI https://scalameta.org/munit/docs/fixtures.html#asynchronous-fixtures-with-custom-effect-type

Edit: I had a look if the new functionality allows me to migrate away from munit-cats-effect, but I had little success in doing so. The new functionality is very limited.

@armanbilge
Copy link
Member Author

Another nail in the coffin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants