New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checking the source code with a static analyzer #188

Open

Yugend opened this issue Jun 4, 2024 · 0 comments

Yugend commented Jun 4, 2024

Hello! I checked the source code of e2fsprogs using a static analyzer and found a couple of suspicious places.
Here they are:

misc/e4crypt.c file, 225 line.
The memset() call will be deleted by compiler in release build and sensitive data won`t be deleted.
misc/badblocks.c file, 806 line.
If I understand correctly, this loop is never executed because of num_saved=0 in 786 line. It is an old code, so I assume it works correctly, but it looks strange to me and I decided to mention it.

Thank you in advance for the answer, and I apologize for bothering you if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment