scriptlet not working as expected

[uBlock-user]

@gorhill Add deadline.com##+js(rmnt, script, /pmc/) to my filters and browse to https://deadline.com/

In Nightly, press F12 and open dev-tools, upon opening, browse to Inspector pane and if you search for pmc, devtools will hang/lag and will find many instances of pmc in <script> tags even though there should be none(essentially scriptlet has failed to remove pmc ladden js)

In Firefox, repeat the same procedure above, and dev-tools will not hang but scriptlet doesn't work either, evidenced by presense of pmc ladden js as per the searches in Inspector pane of devtools.

Are you seeing this behaviour ?

[gorhill]

It's full of instances of pmc in there outside script tags. When using:

deadline.com##+js(rmnt, script, /pmc/, log, 1)

Then reload the page, I see lot of reports of script tags being emptied, as expected.

---

Note that I get a lot errors such as Uncaught ReferenceError: pmc_breaking_news_hash is not defined or Uncaught ReferenceError: pmcRecaptcha is not defined, with that filter, suggesting it did prevent at least some inline JS from executing.

[gorhill]

I would need to add support in the parser for this. What is the URL of your scriptlet?

[uBlock-user]

https://ubo-scriptlets.pages.dev/scriptlets.js ?

[gorhill]

I've made changes to support world and dependency, gorhill/uBlock@695b93f9708a, I feel it's a safe change to release candidate since this code is not used in normal uBO installation. Usage example for your case:

/// remove-node.js
/// alias rn.js
/// world isolated

I also added dependency if you want to use some of the .fn helpers in https://github.com/gorhill/uBlock/blob/master/assets/resources/scriptlets.js. Example:

/// remove-node.js
/// alias rn.js
/// world isolated
/// dependency pattern-to-regex.fn

The helpers are for internal use first and foremost, and it may happen I change them whenever I feel like doing so, so I offer no guarantee that they will always work as they currently do. You can declare as many dependency as needed.

[uBlock-user]

I couldn't find any list of advantages of using "ISOLATED" over "MAIN" world. Do you mind listing them here ?

[gorhill]

Steps:

• MAIN
  • Firefox:
    • Content script code assembled in background process
    • Content script code injected from background process
    • Content script code create blob: URL containing all scriptlets for the site
    • Content script code add script tag to the DOM with blob: URL as source
    • Scriptlet code executes at some later point when the browser decides to do so
  • Chromium:
    • Content script code assembled in background process
    • Content script code injected from background process
    • Content script code create inline script tag containing all scriptlets as text content
    • Content script code add inline script tag to the DOM
    • Scriptlet code executes immediately upon insertion
• ISOLATED
  • Firefox, Chromium:
    • Content script code assembled in background process
    • Content script code injected from background process
    • Content script code contains scriptlet code, so they execute immediately, no need to insert anything in DOM

MAIN: can access page's variables, ISOLATED can't.