Minimum GOMAXPROCS should be 1 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
==========================================
+ Coverage 93.37% 93.58% +0.21%
==========================================
Files 7 7
Lines 181 187 +6
==========================================
+ Hits 169 175 +6
Misses 10 10
Partials 2 2
Continue to review full report at Codecov.
|
akshayjshah
approved these changes
Nov 10, 2017
maxprocs/maxprocs.go
Outdated
| // Min sets the minimum GOMAXPROCS value that will be used. | ||
| func Min(n int) Option { | ||
| return optionFunc(func(cfg *config) { | ||
| cfg.minGOMAXPROCS = n |
There was a problem hiding this comment.
Might be worth either handling n<1 or noting in the docs that passing n<1 leaves GOMAXPROCS unchanged.
There was a problem hiding this comment.
Good idea, will note that GOMAXPROCS < 1 will have no affect.
jasonlai
approved these changes
Nov 10, 2017
We previously set the minimum GOMAXPROCS value to 2 as that was the minimum allocation we expected internally. However, if the allocation is actually smaller, we should use lower GOMAXPROCS. This will also allow us to reduce the allocation size and use a more appropriate GOMAXPROCS which will reduce the amount of CFS throttling.
prashantv
force-pushed
the
min_gomaxprocs
branch
from
b2d808b
to
c405dbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously set the minimum GOMAXPROCS value to 2 as that was the
minimum allocation we expected internally. However, if the allocation is
actually smaller, we should use lower GOMAXPROCS.
This will also allow us to reduce the allocation size and use a more
appropriate GOMAXPROCS which will reduce the amount of CFS throttling.