From d81295331b511de35b89d52ebc7195bf653a9884 Mon Sep 17 00:00:00 2001 From: Abhinav Gupta Date: Tue, 13 Feb 2024 13:19:13 -0800 Subject: [PATCH] deadlineCtx.Err: Use defer Co-authored-by: Jacob Oaks --- internal/fxclock/clock.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/internal/fxclock/clock.go b/internal/fxclock/clock.go index 6a2bdbcdc..d15aabddd 100644 --- a/internal/fxclock/clock.go +++ b/internal/fxclock/clock.go @@ -161,9 +161,8 @@ func (c *deadlineCtx) Value(key any) any { return c.inner. func (c *deadlineCtx) Err() error { c.mu.Lock() - err := c.err - c.mu.Unlock() - return err + defer c.mu.Unlock() + return c.err } func (c *deadlineCtx) cancel(err error) {