-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make DPanic an actual level and replace DFatal #175
Comments
My proposal:
|
akshayjshah
changed the title
Fix DFatal (espec. wrt sampled logging)
Make DPanic an actual level and replace DFatal
Nov 29, 2016
@jcorbin Plan makes sense, but let's replace DFatal with DPanic. It accomplishes the same blow-up-in-dev goal (and actually dumps a stack trace with the panic), and it fits more neatly into the level hierarchy between |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
DFatal not being an explicit log level, but instead an implementation detail of Meta, hurts composability:
The text was updated successfully, but these errors were encountered: