Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider separating leaf and middleware Facilities #224

Closed
akshayjshah opened this issue Jan 3, 2017 · 2 comments
Closed

Consider separating leaf and middleware Facilities #224

akshayjshah opened this issue Jan 3, 2017 · 2 comments
Assignees
@jcorbin
Labels
enhancement

Comments

@akshayjshah
Copy link
Contributor

(Relevant only to the dev branch. See the large "Facilities could be further broken up" comment on #201.)

Facilities are either (1) middleware for other facilities (e.g., sampling or teeling) or (2) leaves, like the ioFacility. Consider separating these types so that implementors need to write less boilerplate.
@akshayjshah akshayjshah added this to the 1.0.0 milestone Jan 3, 2017
@jcorbin jcorbin self-assigned this Jan 3, 2017
@jcorbin
Copy link
Contributor

jcorbin commented Jan 3, 2017

Prior thought on this direction describe in #201 (comment)

@jcorbin jcorbin mentioned this issue Jan 11, 2017
Closed
@jcorbin jcorbin removed this from the 1.0.0 milestone Jan 12, 2017
@akshayjshah
Copy link
Contributor Author

We ended up punting on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcorbin jcorbin

Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcorbin @akshayjshah