Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SugaredLogger #185

Merged
merged 31 commits into from
Jan 19, 2017
Merged

Add SugaredLogger #185

merged 31 commits into from
Jan 19, 2017

Commits on Jan 13, 2017

  1. Refs: #138

    @mikluko
    mikluko authored and Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    ccd2c79 View commit details
    Browse the repository at this point in the history

  2. added benchmark

    @mikluko
    mikluko authored and Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    2f71959 View commit details
    Browse the repository at this point in the history

  3. improved test coverage

    @mikluko
    mikluko authored and Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    f83f8a7 View commit details
    Browse the repository at this point in the history

  4. improved test coverage even more

    @mikluko
    mikluko authored and Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    d19b6d2 View commit details
    Browse the repository at this point in the history

  5. accept error as the first of variadic arguments

    @mikluko
    mikluko authored and Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    3e840ad View commit details
    Browse the repository at this point in the history

  6. cleanup

    @mikluko
    mikluko authored and Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    e05c023 View commit details
    Browse the repository at this point in the history

  7. improved coverage

    @mikluko
    mikluko authored and Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    f2a8f56 View commit details
    Browse the repository at this point in the history

  8. mirrored relevant core logger benchmarks

    @mikluko
    mikluko authored and Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    9c9b46b View commit details
    Browse the repository at this point in the history

  9. use CheckedMessage to cut off expensive argument parsing

    @mikluko
    mikluko authored and Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    73a65b2 View commit details
    Browse the repository at this point in the history

  10. used another form of type switch

    @mikluko
    mikluko authored and Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    859883a View commit details
    Browse the repository at this point in the history

  11. fixed typo

    @mikluko
    mikluko authored and Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    f869f0d View commit details
    Browse the repository at this point in the history

  12. getSugarFields errors are logged rather then returned

    @mikluko
    mikluko authored and Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    3786a4a View commit details
    Browse the repository at this point in the history

  13. added support for Marshaler field, changed fallback from error to obj… 

    …ect field
    @mikluko
    mikluko authored and Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    276f677 View commit details
    Browse the repository at this point in the history

  14. pre-allocate fields slice

    @mikluko
    mikluko authored and Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    79c05a6 View commit details
    Browse the repository at this point in the history

  15. made test to fail if Object field is used in place of Marshaler

    @mikluko
    mikluko authored and Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    a0a3ee6 View commit details
    Browse the repository at this point in the history

  16. Removed LogMarshaler handling

    @mikluko
    mikluko authored and Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    7bb19f1 View commit details
    Browse the repository at this point in the history

  17. added some benchamrk helpers to reduce repeats

    @mikluko
    mikluko authored and Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    ef67c88 View commit details
    Browse the repository at this point in the history

  18. updated comments

    @mikluko
    mikluko authored and Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    3311b28 View commit details
    Browse the repository at this point in the history

  19. handle errors same way core logger does

    @mikluko
    mikluko authored and Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    3cc2db3 View commit details
    Browse the repository at this point in the history

  20. relay DFatal directly to core logger

    @mikluko
    mikluko authored and Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    40bb388 View commit details
    Browse the repository at this point in the history

  21. benchmark fix

    @mikluko
    mikluko authored and Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    6e41219 View commit details
    Browse the repository at this point in the history

  22. WIP, addressing comments on @akabos's PR

    Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    a5a3dac View commit details
    Browse the repository at this point in the history

  23. Finish sugared logger, update tests & benchmarks

    Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    55b8718 View commit details
    Browse the repository at this point in the history

  24. Update the benchmarks

    Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    96da776 View commit details
    Browse the repository at this point in the history

  25. Fix benchmarks 

    The sugared logger benchmarks were artificially good because we weren't logging
anything :/
    Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    ceba454 View commit details
    Browse the repository at this point in the history

  26. Add test coverage for zap.Any

    Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    3c9b89e View commit details
    Browse the repository at this point in the history

  27. With should dispatch to WithFields

    Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    c4c498f View commit details
    Browse the repository at this point in the history

  28. Update to use internal observer package

    Akshay Shah committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    1e2740d View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2017

  1. Some CR

    Akshay Shah committed Jan 14, 2017
    Configuration menu
    Copy the full SHA
    2698eca View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2017

  1. Don't expose structured fields or checking 

    Keep the sugared API wholly separate from the unsugared API: don't expose a way
to add plan `zapcore.Field`s to the context, and don't plan to expose a checked
entry API. This cleans up the sugared logger implementation.

Since the sugared logger is a concrete type and not an interface, we can always
add these curlicues back later.
    Akshay Shah committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    41649e4 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2017

  1. Compromise on message type 

    Compromise on the type of the message: for the context-adding methods, accept
only strings, but also provide Sprint-style methods that take ...interface{}.
    Akshay Shah committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    9f66b60 View commit details
    Browse the repository at this point in the history