Add support for remaining array types #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add wrappers for common array types. This fixes #136.
jcorbin
reviewed
Feb 1, 2017
|
|
||
| // Durations constructs a field that carries a slice of time.Durations. Like | ||
| // Duration, it represents each duration as an integer number of nanoseconds. | ||
| func Durations(key string, ds []time.Duration) zapcore.Field { |
There was a problem hiding this comment.
It's especially bizarre that we have this, but not the singular (nor special encoder support for it); in the vein of my comment on #258 .
jcorbin
approved these changes
Feb 1, 2017
|
Indeed! |
akshayjshah
added a commit
that referenced
this pull request
Feb 1, 2017
Add wrappers for common array types. This fixes #136.
akshayjshah
added a commit
that referenced
this pull request
Feb 1, 2017
akshayjshah
added a commit
that referenced
this pull request
Feb 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add wrappers for common array types. This fixes #136.
(Note that this is stacked on top of #258.)