Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename hammer.d -> hammer.mk #616

Open
jwright6323 opened this issue Aug 13, 2021 · 1 comment · May be fixed by #814
Open

Rename hammer.d -> hammer.mk #616

jwright6323 opened this issue Aug 13, 2021 · 1 comment · May be fixed by #814
Labels
beginner PR Good for newcomers Chipyard This pertains to ucb-bar/chipyard integration low priority Easy workaround exists, regular QoL issue

Comments

@jwright6323
Copy link
Contributor

This is more consistent with other included Makefiles (is .d even correct?)
@jwright6323 jwright6323 added low priority Easy workaround exists, regular QoL issue beginner PR Good for newcomers Chipyard This pertains to ucb-bar/chipyard integration labels Aug 13, 2021
@harrisonliew
Copy link
Contributor

I support this. Though there's no standard, the GNU Make manual seems to imply .mk should be used: https://www.gnu.org/software/make/manual/html_node/Include.html

However, this will break existing wrapper Makefiles in Chipyard, labs, etc.

@harrisonliew harrisonliew linked a pull request Oct 27, 2023 that will close this issue
Draft
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner PR Good for newcomers Chipyard This pertains to ucb-bar/chipyard integration low priority Easy workaround exists, regular QoL issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Top-down hierarchical ucb-bar/hammer
2 participants
@jwright6323 @harrisonliew