Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect.py --save-crop bug #5544

Closed
1 of 2 tasks
Zengyf-CVer opened this issue Nov 6, 2021 · 2 comments · Fixed by #5545
Closed
1 of 2 tasks

detect.py --save-crop bug #5544

Zengyf-CVer opened this issue Nov 6, 2021 · 2 comments · Fixed by #5545
Labels
bug Something isn't working

Comments

@Zengyf-CVer
Copy link
Contributor

Search before asking

  • I have searched the YOLOv5 issues and found no similar bug report.

YOLOv5 Component

Detection

Bug

@glenn-jocher
I ran this command:

python detect.py --source ./data/images/bus.jpg --save-crop

As a result, in the directories of each category in the crops directory, all the pictures have become folders.

ksnip_20211107-012859
ksnip_20211107-012918

Environment

No response

Minimal Reproducible Example

No response

Additional

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@Zengyf-CVer Zengyf-CVer added the bug Something isn't working label Nov 6, 2021
@glenn-jocher
Copy link
Member

@Zengyf-CVer thanks for the bug report! Yes I'm able to reproduce the same bug. It's likely related to the recent updates to increment_path(), I'll investigate.

@glenn-jocher glenn-jocher changed the title About detect.py's save-crop bug detect.py --save-crop bug Nov 6, 2021
@glenn-jocher
Copy link
Member

@Zengyf-CVer good news 😃! Your original issue may now be fixed ✅ in PR #5545. To receive this update:

  • Gitgit pull from within your yolov5/ directory or git clone https://github.com/ultralytics/yolov5 again
  • PyTorch Hub – Force-reload model = torch.hub.load('ultralytics/yolov5', 'yolov5s', force_reload=True)
  • Notebooks – View updated notebooks Open In Colab Open In Kaggle
  • Dockersudo docker pull ultralytics/yolov5:latest to update your image Docker Pulls

Thank you for spotting this issue and informing us of the problem. Please let us know if this update resolves the issue for you, and feel free to inform us of any other issues you discover or feature requests that come to mind. Happy trainings with YOLOv5 🚀!

@glenn-jocher glenn-jocher linked a pull request Nov 6, 2021 that will close this issue
@glenn-jocher glenn-jocher removed the TODO label Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants