Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Save and preview" bug for pages with and without content in different languages #12884

Closed
jloAwave opened this issue Aug 23, 2022 · 2 comments
Closed

Comments

@jloAwave
Copy link

jloAwave commented Aug 23, 2022

Which exact Umbraco version are you using? For example: 9.0.1 - don't just write v9

9.3.0

Bug summary

Save and Preview doesn't work in certain cases in that it's unable to load the correct culture (language).
Note that the attached video is from Umbraco 9.3.0 but the bug can be reproduced on Umbraco 8, 9 and 10.

Specifics

umbraco-23-aug-2022.mp4

https://umbraco9demo.a-demo.net/umbraco#/content/content/edit/1106?mculture=en-US

Steps to reproduce

See the attached recording. You need at least two languages to be available to reproduce the issue. Make sure you have a page with some content in a language and no content in another language, in the recording, it's "test English version" under Root > Home.

  1. On the language where you have content for the page, click "Save and preview" and see that the culture is correct in the URL
  2. Switch to another language where you have no content for that page, click "Save and preview", see that there's no culture in the URL (but there's no content to preview here anyway)
  3. Switch back to the original language with content and click "Save and preview" and see that the culture is missing from the URL, i.e. the preview fails to load

Expected result / actual result

Expected result: the preview is loaded in and works regardless of switching between languages on pages with or without content

Actual result: if you switch between languages, the preview fails unless you refresh the page before trying to access the preview (see the video)


This item has been added to our backlog AB#24043

@github-actions
Copy link

Hi there @jloAwave!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@lassefredslund lassefredslund added the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Nov 10, 2022
@iOvergaard iOvergaard added state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks and removed state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks labels Nov 10, 2022
@kjac kjac self-assigned this Nov 21, 2022
@Zeegaan
Copy link
Member

Zeegaan commented Nov 23, 2022

Hey @jloAwave Thanks for reporting this!
This is now fixed in #13455

@Zeegaan Zeegaan closed this as completed Nov 23, 2022
@Zeegaan Zeegaan added release/10.4.0 and removed state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks labels Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants