-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation error still triggered after fixing amount on block list #15368
Comments
Hi there @bmoore99! Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better. We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.
We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Hey! Thanks for reporting this issue! 😄 I was able to reproduce it on versions 12.3.3, 13.0.0-rc3, and 10.8.0. It seems that if you do not press save at all and only Save and publish, you do not get the error. But if you press Save when there is a validation error, you run into this issue. setting the property to mandatory is not necessary to reproduce this issue. The issue also affects the BlockGridEditor. I will go ahead and mark this issue as an up for grabs! 😄 |
Hi @bmoore99, We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know. For more information about issues and states, have a look at this blog post. Thanks muchly, from your friendly Umbraco GitHub bot :-) |
I can look at this one. |
I am no longer working on this one. |
Pretty sure this also happens with the "title" of the node, if you create a node and fill nothing in. Then save the page, this will cause the validation errors to appears correctly. Now fill out all of the fields including the node title and save and publish. You will see the validation for the title still triggers even though it has correctly been filled out. Nothing is saved. Same bug, or should I raise another? |
Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)
12.2.0
Bug summary
If a block list has a max amount, saving more than that amount then reducing the amount to fix the validation error still fails to publish.
Specifics
Checked on Chrome and Safari browsers.
Steps to reproduce
Create a simple block list data type with a single block option and max amount set to 1.
Use this block list on a required property type.
Create content with this property and add 2 items in this block list then save (buggy error message btw).
Remove 1 item then click the "Save and publish" button.
Note the user can only proceed to publish this page if they first click the "Save" button or leave the page and go back.
Expected result / actual result
Should be able to "Save and publish" successfully after reducing the block list amount to a valid amount.
The text was updated successfully, but these errors were encountered: