Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v14-rc1 - Duplicate content item - no errors if destination not picked #16098

Closed
mjpraxis opened this issue Apr 18, 2024 · 3 comments · Fixed by umbraco/Umbraco.CMS.Backoffice#1990

Comments

@mjpraxis
Copy link

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

v14-rc2

Bug summary

No errormessage or help when destination not picked when making duplicate of content item.

Specifics

No response

Steps to reproduce

Create document type and content node.

Pick "Duplicate to" on content node

Click "Duplicate" in modal - DO NOT pick any items in content tree

image

Nothing happens

Expected result / actual result

There a kind of indication of error in the console
image

Expected some kind of toastmessage or errormessage.

Or maybe even better - the "Duplicate" button is inactive until content tree item is picked in the modal.

Side note: If you in the modal pick an item and the un-select item. There is an error in the console that says that "Selection is required".
image

Copy link

Hi there @mjpraxis!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@elit0451 elit0451 changed the title v14-rc2 - Duplicate content item - no errors if destination not picked v14-rc1 - Duplicate content item - no errors if destination not picked Apr 19, 2024
@elit0451
Copy link
Member

elit0451 commented Apr 19, 2024

Hi again @mjpraxis 👋

Thanks for reaching out! I can indeed reproduce the 2 related unexpected behaviours when trying to duplicate an item:

  • There is no validation of whether a destination is picked when trying to duplicate a content item;
  • If you unselect a destination, there is a validation error in the Console that "Selection is required".

We will have a look 🙂

@Migaroez
Copy link
Contributor

Still an issue in RC5

duplicate.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants