Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove workaround for rustc extern crate stack overflow bug #1401

Closed
echeran opened this issue Dec 15, 2021 · 0 comments · Fixed by #1402
Closed

Remove workaround for rustc extern crate stack overflow bug #1401

echeran opened this issue Dec 15, 2021 · 0 comments · Fixed by #1402
Assignees
@echeran
Labels
C-unicode Component: Props, sets, tries S-tiny Size: Less than an hour (trivial fixes) T-techdebt Type: ICU4X code health and tech debt
Milestone
2021 Q4 0.5 Sprint D

Comments

@echeran
Copy link
Contributor

echeran commented Dec 15, 2021

Given that rust-lang/rust#87932 has been resolved, we can remove the workarounds we put in place in the lib.rs for both of utils/codepointtrie and utils/uniset.
@echeran echeran added C-unicode Component: Props, sets, tries T-techdebt Type: ICU4X code health and tech debt S-tiny Size: Less than an hour (trivial fixes) labels Dec 15, 2021
@echeran echeran added this to the 2021 Q4 0.5 Sprint D milestone Dec 15, 2021
@echeran echeran self-assigned this Dec 15, 2021
@echeran echeran mentioned this issue Dec 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@echeran echeran

Labels
C-unicode Component: Props, sets, tries S-tiny Size: Less than an hour (trivial fixes) T-techdebt Type: ICU4X code health and tech debt
Projects
None yet
Milestone
2021 Q4 0.5 Sprint D
Development

Successfully merging a pull request may close this issue.

Remove workaround for rustc bug after upstream fix echeran/icu4x
1 participant
@echeran