New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace manual url concatenation with `urllib.parse.urljoin` or similar #31

Open

pederhan opened this issue Feb 27, 2023 · 0 comments

Labels

enhancement good first issue

Member

pederhan commented Feb 27, 2023

Concatenating URLs manually is pretty silly, when there are utility functions for this in the standard library.

https://github.com/pederhan/harborapi/blob/5ce05adc3531f203725222c4e3ffacd03a505582/harborapi/client.py#L3607-L3612

We should replace this with a utility function that all HTTP methods can re-use.

pederhan added enhancement good first issue labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment