From 21cc0e13d549b515a03c522089d41db05b07ce1a Mon Sep 17 00:00:00 2001
From: Terje Kvernes <terje@kvernes.no>
Date: Wed, 29 May 2024 12:52:45 +0200
Subject: [PATCH] "Fix" and test filtering for HostFilterSet. :(

---
 mreg/api/v1/filters.py     |  6 ++++++
 mreg/api/v1/tests/tests.py | 31 ++++++++++++++++++++++++++++++-
 2 files changed, 36 insertions(+), 1 deletion(-)

diff --git a/mreg/api/v1/filters.py b/mreg/api/v1/filters.py
index 8ea3e011..28e8b633 100644
--- a/mreg/api/v1/filters.py
+++ b/mreg/api/v1/filters.py
@@ -65,6 +65,12 @@ class Meta:
 
 
 class HostFilterSet(filters.FilterSet):
+
+    # It's weird that we have to define the id field here, but it's necessary for the filters to work.
+    id = filters.NumberFilter(field_name="id")
+    id__in = filters.BaseInFilter(field_name="id")
+    id__gt = filters.NumberFilter(field_name="id", lookup_expr="gt")
+    id__lt = filters.NumberFilter(field_name="id", lookup_expr="lt")
     class Meta:
         model = Host
         fields = "__all__"
diff --git a/mreg/api/v1/tests/tests.py b/mreg/api/v1/tests/tests.py
index 6b4a3e49..b5efc099 100644
--- a/mreg/api/v1/tests/tests.py
+++ b/mreg/api/v1/tests/tests.py
@@ -474,9 +474,38 @@ def setUp(self):
         clean_and_save(self.host_one)
         clean_and_save(self.host_two)
 
+    def _one_hit_and_host_one(self, query: str):        
+        """Check that we only have one hit and it is host_one"""
+        response = self.assert_get(f"/hosts/?{query}")
+        hits = response.json()['results']
+        self.assertEqual(len(hits), 1)
+        self.assertEqual(hits[0]['name'], self.host_one.name)
+
     def test_hosts_get_200_ok(self):
         """"Getting an existing entry should return 200"""
-        self.assert_get('/hosts/%s' % self.host_one.name)
+        self.assert_get('/hosts/%s' % self.host_one.name)    
+
+    def test_host_get_200_ok_by_id(self):
+        """Getting an existing entry by id should return 200"""
+        self._one_hit_and_host_one(f"id={self.host_one.id}")
+
+    def test_host_get_200_ok_by_id_gt_and_lt(self):
+        """Getting an existing entry by id should return 200"""
+        id = self.host_one.id
+        (id_after, id_before) = (id + 1, id - 1)
+        self._one_hit_and_host_one(f"id__gt={id_before}&id__lt={id_after}")
+
+    def test_host_get_200_ok_by_id_in(self):
+        """Getting an existing entry by id should return 200"""
+        self._one_hit_and_host_one(f"id__in={self.host_one.id}")
+
+    def test_host_get_200_ok_by_contact(self):
+        """Getting an existing entry by ip should return 200"""
+        self._one_hit_and_host_one(f"contact={self.host_one.contact}")
+
+    def test_host_get_200_ok_by_name(self):
+        """Getting an existing entry by name should return 200"""
+        self._one_hit_and_host_one(f"name={self.host_one.name}")
 
     def test_hosts_get_case_insensitive_200_ok(self):
         """"Getting an existing entry should return 200"""