Skip to content

Commit

Permalink
feat!: include dual cjs/esm in package exports (#330)
Browse files Browse the repository at this point in the history
  • Loading branch information
userquin authored Nov 29, 2023
1 parent 091fec6 commit 67642e2
Show file tree
Hide file tree
Showing 5 changed files with 140 additions and 58 deletions.
104 changes: 75 additions & 29 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,40 +15,75 @@
"bugs": "https://github.com/unplugin/unplugin-icons/issues",
"exports": {
".": {
"types": "./dist/index.d.ts",
"import": "./dist/index.mjs",
"require": "./dist/index.cjs"
"import": {
"types": "./dist/index.d.ts",
"default": "./dist/index.js"
},
"require": {
"types": "./dist/index.d.cts",
"default": "./dist/index.cjs"
}
},
"./*": "./*",
"./esbuild": {
"types": "./dist/esbuild.d.ts",
"import": "./dist/esbuild.mjs",
"require": "./dist/esbuild.cjs"
"import": {
"types": "./dist/esbuild.d.ts",
"default": "./dist/esbuild.js"
},
"require": {
"types": "./dist/esbuild.d.cts",
"default": "./dist/esbuild.cjs"
}
},
"./loaders": {
"types": "./dist/loaders.d.ts",
"import": "./dist/loaders.mjs",
"require": "./dist/loaders.cjs"
"import": {
"types": "./dist/loaders.d.ts",
"default": "./dist/loaders.js"
},
"require": {
"types": "./dist/loaders.d.cts",
"default": "./dist/loaders.cjs"
}
},
"./nuxt": {
"types": "./dist/nuxt.d.ts",
"import": "./dist/nuxt.mjs",
"require": "./dist/nuxt.cjs"
"import": {
"types": "./dist/nuxt.d.ts",
"default": "./dist/nuxt.js"
},
"require": {
"types": "./dist/nuxt.d.cts",
"default": "./dist/nuxt.cjs"
}
},
"./resolver": {
"types": "./dist/resolver.d.ts",
"import": "./dist/resolver.mjs",
"require": "./dist/resolver.cjs"
"import": {
"types": "./dist/resolver.d.ts",
"default": "./dist/resolver.js"
},
"require": {
"types": "./dist/resolver.d.cts",
"default": "./dist/resolver.cjs"
}
},
"./rollup": {
"types": "./dist/rollup.d.ts",
"import": "./dist/rollup.mjs",
"require": "./dist/rollup.cjs"
"import": {
"types": "./dist/rollup.d.ts",
"default": "./dist/rollup.js"
},
"require": {
"types": "./dist/rollup.d.cts",
"default": "./dist/rollup.cjs"
}
},
"./types": {
"types": "./dist/types.d.ts",
"import": "./dist/types.mjs",
"require": "./dist/types.cjs"
"import": {
"types": "./dist/types.d.ts",
"default": "./dist/types.js"
},
"require": {
"types": "./dist/types.d.cts",
"default": "./dist/types.cjs"
}
},
"./types/astro": {
"types": "./types/astro.d.ts"
Expand Down Expand Up @@ -84,18 +119,28 @@
"types": "./types/web-components.d.ts"
},
"./vite": {
"types": "./dist/vite.d.ts",
"import": "./dist/vite.mjs",
"require": "./dist/vite.cjs"
"import": {
"types": "./dist/vite.d.ts",
"default": "./dist/vite.js"
},
"require": {
"types": "./dist/vite.d.cts",
"default": "./dist/vite.cjs"
}
},
"./webpack": {
"types": "./dist/webpack.d.ts",
"import": "./dist/webpack.mjs",
"require": "./dist/webpack.cjs"
"import": {
"types": "./dist/webpack.d.ts",
"default": "./dist/webpack.js"
},
"require": {
"types": "./dist/webpack.d.cts",
"default": "./dist/webpack.cjs"
}
}
},
"main": "dist/index.cjs",
"module": "dist/index.mjs",
"module": "dist/index.js",
"types": "dist/index.d.ts",
"typesVersions": {
"*": {
Expand All @@ -111,7 +156,7 @@
"types"
],
"scripts": {
"build": "esno scripts/prebuild.ts && tsup && esno scripts/postbuild.ts",
"build": "esno scripts/prebuild.ts && tsup",
"dev": "esno scripts/prebuild.ts && tsup --watch src",
"example:build": "npm -C examples/vite-vue3 run build",
"example:dev": "npm -C examples/vite-vue3 run dev",
Expand Down Expand Up @@ -170,6 +215,7 @@
"eslint": "^8.53.0",
"esno": "^4.0.0",
"fast-glob": "^3.3.2",
"publint": "^0.2.5",
"rollup": "^4.4.0",
"tsup": "^7.2.0",
"typescript": "^5.2.2",
Expand Down
61 changes: 61 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 0 additions & 23 deletions scripts/postbuild.ts

This file was deleted.

3 changes: 3 additions & 0 deletions src/core/icon-sets.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@
"iwwa",
"jam",
"la",
"lets-icons",
"line-md",
"logos",
"ls",
Expand All @@ -98,6 +99,7 @@
"maki",
"map",
"material-symbols",
"material-symbols-light",
"mdi",
"mdi-light",
"medical-icon",
Expand All @@ -106,6 +108,7 @@
"mi",
"mingcute",
"mono-icons",
"mynaui",
"nimbus",
"nonicons",
"noto",
Expand Down
7 changes: 1 addition & 6 deletions tsup.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export const tsup: Options = {
splitting: true,
clean: true,
dts: true,
entryPoints: [
entry: [
'src/*.ts',
],
format: [
Expand All @@ -15,9 +15,4 @@ export const tsup: Options = {
'vue',
'@iconify/json/package.json',
],
outExtension({ format }) {
return {
js: format === 'cjs' ? '.cjs' : '.mjs',
}
},
}

0 comments on commit 67642e2

Please sign in to comment.