Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

six usage is redundant #390

Open
pgajdos opened this issue Mar 16, 2023 · 4 comments
Open

six usage is redundant #390

pgajdos opened this issue Mar 16, 2023 · 4 comments

Comments

@pgajdos
Copy link

pgajdos commented Mar 16, 2023

As you declare that this package is 3.6+, could you please consider drop of dependency on six please?

@lachmanfrantisek
Copy link
Member

Hi @pgajdos !

Yes, that's a good suggestion. This will also require a bit of code cleanup as well...

Do you think you can take a look at that and get rid of it?
https://github.com/user-cont/conu/search?q=six&type=code

I'll take a look otherwise...

@pgajdos
Copy link
Author

pgajdos commented Mar 20, 2023

Nazdar!

https://build.opensuse.org/package/view_file/devel:languages:python/python-conu/python-conu-no-six.patch

This works with 'not (integration or test_get_port_mappings or selinux or ownership)' pytest run, detailed build log can be found here:

https://build.opensuse.org/package/live_build_log/home:pgajdos:python/python-conu/openSUSE_Tumbleweed/x86_64

I am not 100% sure this is complete, though.

Petr

@jpopelka
Copy link
Member

Nazdar :)

I could apply your patch, but it'd be better if you created a pull request with the change so that

  • we can discuss the code there
  • you'll be recorded as an author in the history of the repo

@pgajdos
Copy link
Author

pgajdos commented Mar 21, 2023

I think it is clear I am unsure I can do an upstream class submission, but here you are. Sure we can discuss, but I do not aspire to be author of this change if not necessary ;).

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this issue Mar 21, 2023
https://build.opensuse.org/request/show/1073107
by user mcepl + dimstar_suse
- do not require six
- added patches
  fix user-cont/conu#390
  + python-conu-no-six.patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants