This repository has been archived by the owner on May 16, 2022. It is now read-only.
Make function checkout back to master #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
TomasTomecek
reviewed
Mar 9, 2019
| @@ -429,6 +429,7 @@ def make_release_pr(self, new_pr): | |||
| name, email = self.get_user_contact() | |||
| repo.set_credentials(name, email) | |||
| repo.set_credential_store() | |||
| repo.checkout('master') | |||
There was a problem hiding this comment.
Could you please elaborate why is this needed? Two lines below there is another checkout. Ideally please include a comment in the code.
|
[test] |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the bug #173
make_new_pypi_release() will now check back to master hence will have no side effect to other functions.
make_release_pr() will additionally checkout for master again because its important that the current branch is master before release pr branching
make_release_pr() will also check back to master after doing the release_pr