Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhelpful server response error for incorrect vector response data #1028

Closed
AlexThurston opened this issue Sep 30, 2020 · 3 comments
Closed

Comments

@AlexThurston
Copy link

We ran into a situation where we were pushing a response to a vector set provided by the client which resulted in a 500 and Internal service error. Contact service provider.

After some debugging of what the vendor provided it turns out that their responses had the key vsid rather than vsId which was the cause of the error.

The error provided by ACVP wasn't all that helpful in debugging the issue so I thought I'd raise this to see if there was an improvement. I would have expected a 400 as it was really a bad request and a message describing why.

@Kritner
Copy link
Contributor

Kritner commented Sep 30, 2020

@AlexThurston can you provide more information about the nature of the error? was it on the post of the bad file, or the attempt as getting the verdict of a successfully posted bad file? Do you have a vsId for reference?

From the above comment I'm guessing it was on the post, not the get, but just wanted to double check.

@AlexThurston
Copy link
Author

Sorry, I should have given you more info than what I provided. Although I'm not sure that that the problem is necessarily tied to a specific test session or vector set. I'm pretty sure you could reproduce it using any of them.

Route: POST /testSessions/{testSessionId}/vectorSets/{vectorSetId}/results
Test Session: 116093
Vector Set: 330157

Basically, the response looks like this:

[
    {
        "acvVersion": "1.0"
    },
    {
        "vsid": 330157,
        "testGroups": [
            {...}
        ]
    }  
]

Notice the vsid key has a lower case i where it should have been vsId. This was the problem, but it produced a boilerplate 500 and error which didn't necessarily help debug the issue. At the very least, it should probably be 400.

@dmchodnicki
Copy link
Collaborator

This item has been incorporated into a new Error Code Enhancement ticket and is therefore being Closed. Please refer to #1070 for future updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants