Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federated Patient List datasets (except Demographics) fail #382

Closed
ndobb opened this issue Jan 25, 2021 · 0 comments
Closed

Federated Patient List datasets (except Demographics) fail #382

ndobb opened this issue Jan 25, 2021 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ndobb
Copy link
Member

ndobb commented Jan 25, 2021

The error (in production) appears as:
image

Text.js, referenced in the stacktrace, appears to be part of the Recharts library:
image

The full React error message is
image

So it appears that Recharts is getting update requests from React faster than it expects, and some sort of recursive update is being triggered. This is almost certainly due to federated cohort Demographics requests being processed asynchronously but resolving (with new data) while the Visualization charts are still updating.

We can make an issue in Recharts but in the meantime may need to defensively defer UI updates on the Visualize screen to prevent the error (ugh). Rather than do this in the React component it may be (slightly) less hacky and unsightly to do it in the Redux async function which handles the API requests, so perhaps do so there.

@ndobb ndobb added the bug Something isn't working label Jan 25, 2021
@ndobb ndobb added this to the Leaf v3.9 milestone Jan 25, 2021
@ndobb ndobb self-assigned this Jan 25, 2021
@ndobb ndobb closed this as completed Apr 28, 2021
@ndobb ndobb reopened this May 13, 2021
@ndobb ndobb closed this as completed Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant