Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve name property #14

Merged
merged 1 commit into from
Apr 20, 2022
Merged

refactor: improve name property #14

merged 1 commit into from
Apr 20, 2022

Conversation

vanstinator
Copy link
Owner

Let's expose a friendlier name (will need better ways to translate it at some point) and move model to a bespoke property.

@vanstinator vanstinator enabled auto-merge (squash) April 20, 2022 22:01
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #14 (ec3cbd7) into main (254256f) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   92.12%   92.20%   +0.07%     
==========================================
  Files           5        5              
  Lines         216      218       +2     
==========================================
+ Hits          199      201       +2     
  Misses         17       17              
Impacted Files Coverage Δ
melnor_bluetooth/scanner.py 96.42% <ø> (ø)
melnor_bluetooth/device.py 91.02% <100.00%> (+0.11%) ⬆️

@vanstinator vanstinator merged commit c3a966a into main Apr 20, 2022
@vanstinator vanstinator deleted the refactor/naming branch April 20, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant