Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should concurrent status be passed on along with group_by? #1125

Closed
gaow opened this issue Dec 23, 2018 · 3 comments
Closed

Should concurrent status be passed on along with group_by? #1125

gaow opened this issue Dec 23, 2018 · 3 comments

Comments

@gaow
Copy link
Member

gaow commented Dec 23, 2018

Currently with the new behavior of group_by what I used to specify for a workflow,

[1]
input: group_by = 1, concurrent = True
...
[2]
input: group_by = 1, concurrent = True

now becomes

[1]
input: group_by =1 , concurrent=True
...
[2]
input: concurrent=True

I wonder where information for concurrent is saved, and if it makes sense to make it group property that can also be passed on unless otherwise specified?

@BoPeng
Copy link
Contributor

BoPeng commented Dec 23, 2018

The only case when concurrent should be False is when the next substep depends upon the result of previous ones, and frankly I have not seen a single use case for this in the past few years. With the better control of number of processes now, I suppose we can make concurrent=True the default.

@gaow
Copy link
Member Author

gaow commented Dec 28, 2018

@BoPeng just to double check this: now concurrent=True is default for non-task. It is also True for task, and has been like that for some time already, right?

@BoPeng
Copy link
Contributor

BoPeng commented Dec 28, 2018

Yes. I do not think there is such an option for task (and I will remove it if there is as I am going through the manual).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants