Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add ipykernel optional dependency to dev group #3507

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

dangotbanned
Copy link
Member

@dangotbanned dangotbanned commented Jul 28, 2024

This PR adds the optional ipython dependency ipykernel, to avoid the following issue.

Bug

Attempting to run a notebook

image

Install failing due to uv instead of pip

image

Error command

image

This has to be modified to fix:

# >>> python -m pip install ipykernel -U --force-reinstall
>>> python -m uv pip install ipykernel -U --force-reinstall

I have been manually working around this since we moved from pip -> uv in #3431 (comment)

But this change is much simpler and doesn't need to be repeated for each new environment.

@dangotbanned dangotbanned marked this pull request as ready for review July 28, 2024 12:45
Copy link
Contributor

@binste binste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful, thanks!

@binste binste merged commit 7fe29d3 into vega:main Jul 29, 2024
17 checks passed
@dangotbanned dangotbanned deleted the add-dep-ipykernel branch July 29, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants