From ef96abd421e736bb9c927cd555fcfc38f51a5567 Mon Sep 17 00:00:00 2001 From: eps1lon Date: Thu, 2 May 2024 13:36:18 +0200 Subject: [PATCH] custom scripts fail AMP validation now --- test/integration/amphtml/test/index.test.js | 27 +++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/test/integration/amphtml/test/index.test.js b/test/integration/amphtml/test/index.test.js index b8f049a358fb3..f9959890e01cf 100644 --- a/test/integration/amphtml/test/index.test.js +++ b/test/integration/amphtml/test/index.test.js @@ -31,6 +31,10 @@ describe('AMP Usage', () => { let output = '' beforeAll(async () => { + await rename( + join(appDir, 'pages/custom-scripts.js'), + join(appDir, 'pages/custom-scripts.js.bak') + ) await rename( join(appDir, 'pages/invalid-amp.js'), join(appDir, 'pages/invalid-amp.js.bak') @@ -46,6 +50,10 @@ describe('AMP Usage', () => { app = await nextStart(appDir, context.appPort) }) afterAll(async () => { + await rename( + join(appDir, 'pages/custom-scripts.js.bak'), + join(appDir, 'pages/custom-scripts.js') + ) await rename( join(appDir, 'pages/invalid-amp.js.bak'), join(appDir, 'pages/invalid-amp.js') @@ -536,6 +544,25 @@ describe('AMP Usage', () => { expect(inspectPayload).toContain('error') }) + it('should detect amp validator warning on custom scripts', async () => { + let inspectPayload = '' + dynamicAppPort = await findPort() + ampDynamic = await launchApp(join(__dirname, '../'), dynamicAppPort, { + onStdout(msg) { + inspectPayload += msg + }, + onStderr(msg) { + inspectPayload += msg + }, + }) + + await renderViaHTTP(dynamicAppPort, '/custom-scripts') + + await killApp(ampDynamic) + + expect(inspectPayload).toContain('error') + }) + it('should not contain missing files warning', async () => { expect(output).toContain('Compiled /only-amp') expect(output).not.toContain('Could not find files for')