Enable no-implicit-any-catch

[mrmckeb]

This was a recommendation from @dglsparsons:

We have the useUnknownInCatchVariables setting enabled in our tsconfig (it’s part of the strict family).

But it only applies to try {} catch(e) {} blocks, not to Promise.catch (which is still typed as any). So it causes a kinda weird inconsistency in how exceptions are handled and makes it harder to be type-safe.

There is a typescript issue to update the Promise.catch() behaviour here microsoft/TypeScript#45602, but it is yet to be implemented.

On it, however, it specifically calls out this ESLint rule: https://github.com/cartant/eslint-plugin-etc/blob/main/docs/rules/no-implicit-any-catch.md

I think this would help us be more standardised in how we do exception handling, at least, until the above issue is closed/implemented.

[mrmckeb]

@dglsparsons what do you think of modifying the types instead?

[dglsparsons]

@mrmckeb As in redefining the types of Promise.catch? Is that easy enough to do?

[mrmckeb]

Yes, you can see some examples in the issue you linked:
microsoft/TypeScript#45602 (comment)

It might be worth a shot, but I'm surprised they haven't changed this in TS itself yet.

[dglsparsons]

me too tbh.