Fix #111. Create confirmed dialog before setting remote description.

Thanks to @wakamoleguy and @gavllew
versatica · Jun 15, 2013 · dad84a1 · dad84a1
1 parent 15d83bb
commit dad84a1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "jssip",
   "title": "JsSIP",
   "description": "the Javascript SIP library",
-  "version": "0.3.3-devel",
+  "version": "0.3.4-devel",
   "homepage": "http://jssip.net",
   "author": "José Luis Millán <jmillan@aliax.net>",
   "contributors": [

diff --git a/src/RTCSession.js b/src/RTCSession.js
@@ -840,6 +840,11 @@ RTCSession.prototype.receiveResponse = function(response) {
         break;
       }
 
+      // An error on dialog creation will fire 'failed' event
+      if (!this.createDialog(response, 'UAC')) {
+        break;
+      }
+
       this.rtcMediaHandler.onMessage(
         'answer',
         response.body,
@@ -848,11 +853,6 @@ RTCSession.prototype.receiveResponse = function(response) {
          * SDP Answer fits with Offer. Media will start
          */
         function() {
-          // An error on dialog creation will fire 'failed' event
-          if (!session.createDialog(response, 'UAC')) {
-            return;
-          }
-
           session.sendACK();
           session.status = C.STATUS_CONFIRMED;
           session.started('remote', response);