Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Lang.Expr.t of operations consistent #16

Open
kiranandcode opened this issue May 18, 2022 · 0 comments
Open

Make Lang.Expr.t of operations consistent #16

kiranandcode opened this issue May 18, 2022 · 0 comments
Labels
long-term Longer term requests

Comments

@kiranandcode
Copy link
Member

When converting 1 - 2 into our internal representation, this is captured as the application of function - to two arguments 1 and 2 - i.e `App ("-", [`Int 1; `Int 2]); This is okay.

However, there are some small inconsistencies across the codebase. In particular, I think some parts of the pretty printer assume that binary operators are encoded with parenthesis - i.e as `App ("(-)", [`Int 1; `Int 2]), etc.

We should comb through all functions that operate over Lang.Expr.t and check that they make consistent assumptions about how binary operators are represented.

@kiranandcode kiranandcode added the long-term Longer term requests label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
long-term Longer term requests
Projects
None yet
Development

No branches or pull requests

1 participant