Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

DBA role can not rebuild index #1122

Closed
zhoupengbo opened this issue Jun 9, 2021 · 4 comments
Closed

DBA role can not rebuild index #1122

zhoupengbo opened this issue Jun 9, 2021 · 4 comments
Assignees
Labels
feature req Type: feature request

Comments

@zhoupengbo
Copy link

DBA role can not rebuild index , errors:
PermissionError: No Permission to write space .
why need write space access?

nebula version 2.0.1

@bright-starry-sky
Copy link
Contributor

Good issue, I agree with your suggestion, guess is that all AdminJobs are treated as God permissions. Let's break it down further and allow admin permissions on the following items.

case meta::cpp2::AdminCmd::REBUILD_TAG_INDEX:
case meta::cpp2::AdminCmd::REBUILD_EDGE_INDEX:
case meta::cpp2::AdminCmd::REBUILD_FULLTEXT_INDEX:
case meta::cpp2::AdminCmd::STATS:
case meta::cpp2::AdminCmd::COMPACT:
case meta::cpp2::AdminCmd::FLUSH:

@zhoupengbo
Copy link
Author

Good issue, I agree with your suggestion, guess is that all AdminJobs are treated as God permissions. Let's break it down further and allow admin permissions on the following items.

case meta::cpp2::AdminCmd::REBUILD_TAG_INDEX:
case meta::cpp2::AdminCmd::REBUILD_EDGE_INDEX:
case meta::cpp2::AdminCmd::REBUILD_FULLTEXT_INDEX:
case meta::cpp2::AdminCmd::STATS:
case meta::cpp2::AdminCmd::COMPACT:
case meta::cpp2::AdminCmd::FLUSH:

thank you!

@bright-starry-sky bright-starry-sky self-assigned this Jun 10, 2021
@yixinglu yixinglu added the feature req Type: feature request label Jun 10, 2021
@bright-starry-sky bright-starry-sky removed their assignment Jun 10, 2021
@Shylock-Hg Shylock-Hg self-assigned this Jun 10, 2021
@Shylock-Hg
Copy link
Contributor

Good issue, I agree with your suggestion, guess is that all AdminJobs are treated as God permissions. Let's break it down further and allow admin permissions on the following items.

case meta::cpp2::AdminCmd::REBUILD_TAG_INDEX:
case meta::cpp2::AdminCmd::REBUILD_EDGE_INDEX:
case meta::cpp2::AdminCmd::REBUILD_FULLTEXT_INDEX:
case meta::cpp2::AdminCmd::STATS:
case meta::cpp2::AdminCmd::COMPACT:
case meta::cpp2::AdminCmd::FLUSH:

I think it's ok. Only the balance need write space permission in fact, the others only need write data permission. How do you think?

@wey-gu
Copy link

wey-gu commented Jul 16, 2021

Will close it as it's been inactive for days. Feel free to reopen it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature req Type: feature request
Projects
None yet
Development

No branches or pull requests

5 participants