Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

Suggestions for SHOW STATS #1143

Closed
randomJoe211 opened this issue Jun 16, 2021 · 5 comments
Closed

Suggestions for SHOW STATS #1143

randomJoe211 opened this issue Jun 16, 2021 · 5 comments
Assignees
Labels
question Type: question about the product

Comments

@randomJoe211
Copy link
Contributor

randomJoe211 commented Jun 16, 2021

  1. SUBMIT JOB STATS and SHOW STATS is a combined workflow, instead of running them separately, why not make them one statement?
  2. If a user has never run SUBMIT JOB STATS but tries to run SHOW STATS directly, the error Key not existed is returned. This error message is confusing. Maybe it should say something like "To make statistics of the graph space, run SUBMIT JOB STATS first, and then run SHOW STATS." And if suggestion 1 is adapted, there would be no such issue.
    image
@HarrisChu HarrisChu added the question Type: question about the product label Jun 16, 2021
@HarrisChu
Copy link
Contributor

HarrisChu commented Jun 16, 2021

for question 1,
SUBMIT JOB STATS statement starts a job that makes the statistics of the CURRENT graph space.
SHOW STATS means show the previous job statistics.

if make them one statement, it would alway start a new job, it's not comfortable for big data.

@randomJoe211
Copy link
Contributor Author

for question 1,
SUBMIT JOB STATS statement starts a job that makes the statistics of the CURRENT graph space.
SHOW STATS means show the preview job statistics.

if make them one statement, it would alway start a new job, it's not comfortable for big data.

That makes sense. Thank you for the explanation. Then there is only question 2 left.

@panda-sheep
Copy link
Contributor

Good catch, the problem of error message, I will improve it later, thank you

@panda-sheep panda-sheep self-assigned this Jun 20, 2021
@panda-sheep
Copy link
Contributor

has fixed.

@panda-sheep
Copy link
Contributor

refer to vesoft-inc/nebula#2577

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Type: question about the product
Projects
None yet
Development

No branches or pull requests

3 participants