Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support concat for VID #244

Closed
veezhang opened this issue Dec 7, 2022 · 3 comments
Closed

Support concat for VID #244

veezhang opened this issue Dec 7, 2022 · 3 comments
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@veezhang
Copy link
Contributor

veezhang commented Dec 7, 2022

Introduction

Support concat with constant, field or mixed for VID.

Contents

Related work

@veezhang veezhang added the type/enhancement Type: make the code neat or more efficient label Dec 7, 2022
@wey-gu
Copy link
Contributor

wey-gu commented Dec 12, 2022

If we support this, a lot of Transform Work will be no longer needed(it will be extremely friendly to users!❤️), and we could extend its concat capability to vids and any other columns.

@veezhang
Copy link
Contributor Author

@wey-gu I feel that the props should be split as small as possible. Is it necessary to support concat for props?

@wey-gu
Copy link
Contributor

wey-gu commented Dec 13, 2022

@wey-gu I feel that the props should be split as small as possible. Is it necessary to support concat for props?

If from implementation perspective, it's a lot of effort to do so, please ignore it, I am not sure if it's necessary, as the reason I would like to request concat was on VID. But there could be the such need, for instance, just in case, we have First name, Last name cols in the data source and would like to have Name as prop :-D.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Type: make the code neat or more efficient
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants