Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect timezone on Distance-Time and Elevation-Time tabs of Track Properties #96

Closed
sandaihu opened this issue Jun 11, 2020 · 1 comment

Comments

@sandaihu
Copy link

There's the following scenario as:

  • in Preferences I have UTC set as the Time Display
  • the GPX file I open saved the timestamps in UTC (as GPX generally does)

If I open the track properties, the Start and End times are correctly shown in UTC:
image

Yet if I change to the Distance-Time or Elevation-Time tabs, the times are displayed in local time (+2 hours):
image

My system-wide timezone is indeed CET/CEST, but shouldn't viking show also these data in UTC, if the Preferences have that set?

Haven't checked yet with v1.8, the above happens with v1.7.

Thanks.

@rnorris
Copy link
Collaborator

rnorris commented Jun 11, 2020

Yes this looks like an oversight; I'm sure this issue is also in v1.8.

IIRC I did have a concern about performance if the time display option was set to 'World' as it might need to recalculate the timezone for every display update - which might be relatively slow - but the code works out the timezone as used in the Statistics display anyway (i.e. only on initial dialog opening).

Unfortunately it simply appears I forgot to change this bit.

Thanks for noticing and raising this issue.

rnorris added a commit that referenced this issue Sep 10, 2020
Note the timezone can effect the date itself, so needs to be used more widely:
.Time related graphs
.Track & Waypoint lists
.Embedded graph tooltip
.Layers tooltips
@rnorris rnorris closed this as completed Sep 10, 2020
TahomaSoft pushed a commit to TahomaSoft/viking that referenced this issue Sep 15, 2020
…isplays

Note the timezone can effect the date itself, so needs to be used more widely:
.Time related graphs
.Track & Waypoint lists
.Embedded graph tooltip
.Layers tooltips
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants