From 6d572a681c390bf26e183907d0389e7ea9b2c94a Mon Sep 17 00:00:00 2001 From: Bruce Weirdan Date: Sun, 4 Feb 2024 15:41:01 -0400 Subject: [PATCH] Apply suggestions from code review --- tests/OverrideTest.php | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/tests/OverrideTest.php b/tests/OverrideTest.php index 17782bc9eca..ab808a06df9 100644 --- a/tests/OverrideTest.php +++ b/tests/OverrideTest.php @@ -6,8 +6,6 @@ use Psalm\Tests\Traits\InvalidCodeAnalysisTestTrait; use Psalm\Tests\Traits\ValidCodeAnalysisTestTrait; -use const DIRECTORY_SEPARATOR; - class OverrideTest extends TestCase { use ValidCodeAnalysisTestTrait; @@ -83,7 +81,7 @@ class C { public function f(): void {} } ', - 'error_message' => 'InvalidOverride - src' . DIRECTORY_SEPARATOR . 'somefile.php:3:25', + 'error_message' => 'InvalidOverride', 'error_levels' => [], 'php_version' => '8.3', ], @@ -97,7 +95,7 @@ class C2 extends C { public function f(): void {} } ', - 'error_message' => 'MissingOverrideAttribute - src' . DIRECTORY_SEPARATOR . 'somefile.php:7:25', + 'error_message' => 'MissingOverrideAttribute', 'error_levels' => [], 'php_version' => '8.3', ], @@ -113,7 +111,7 @@ class C { public function f(): void {} } ', - 'error_message' => 'MissingOverrideAttribute - src' . DIRECTORY_SEPARATOR . 'somefile.php:9:25', + 'error_message' => 'MissingOverrideAttribute', 'error_levels' => [], 'php_version' => '8.3', ], @@ -131,7 +129,7 @@ class C2 extends C { public function __construct() {} } ', - 'error_message' => 'InvalidOverride - src' . DIRECTORY_SEPARATOR . 'somefile.php:10:25', + 'error_message' => 'InvalidOverride', 'error_levels' => [], 'php_version' => '8.3', ], @@ -145,7 +143,7 @@ interface I2 extends I { public function f(): void; } ', - 'error_message' => 'MissingOverrideAttribute - src' . DIRECTORY_SEPARATOR . 'somefile.php:7:25', + 'error_message' => 'MissingOverrideAttribute', 'error_levels' => [], 'php_version' => '8.3', ], @@ -160,7 +158,7 @@ class C2 extends C { private function f(): void {} } ', - 'error_message' => 'InvalidOverride - src' . DIRECTORY_SEPARATOR . 'somefile.php:7:25', + 'error_message' => 'InvalidOverride', 'error_levels' => [], 'php_version' => '8.3', ], @@ -171,7 +169,7 @@ interface I { public function f(): void; } ', - 'error_message' => 'InvalidOverride - src' . DIRECTORY_SEPARATOR . 'somefile.php:3:25', + 'error_message' => 'InvalidOverride', 'error_levels' => [], 'php_version' => '8.3', ],