assert(!array_is_list()) changes type to be maybe list

[othercorey]

A parameter of type array<string, mixed is passed to another parameter of the same type array<string, mixed>. However, when introducing an assert that it is associative, it seems to think the array could now be a list.

https://psalm.dev/r/715994eafd

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/c7b80db58a

<?php

/** param array<string, mixed> $input1 */
function test(array $input1): array {
    return $input1;
}

/** param array<string, mixed> $input2 */
function test2(array $input2 = []): void {
    assert(empty($input2) || !array_is_list($input2), "Must be associative");
    
    test($input2);
}

Psalm output (using commit 8e0fd88):

No issues!

[weirdan]

@othercorey you omitted @ in @param, that's why you couldn't reproduce it on psalm.dev. Here's the fixed reproducer: https://psalm.dev/r/715994eafd

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/715994eafd

<?php

/** @param array<string, mixed> $input1 */
function test(array $input1): array {
    return $input1;
}

/** @param array<string, mixed> $input2 */
function test2(array $input2 = []): void {
    assert(empty($input2) || !array_is_list($input2), "Must be associative");
    
    test($input2);
}

Psalm output (using commit 8e0fd88):

ERROR: InvalidArgument - 12:10 - Argument 1 of test expects array<string, mixed>, but array<int<0, max>|string, mixed> provided

[othercorey]

Thanks. I updated the description with your example so it's not confusing to read.