Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken code coverage #828

Closed
fpoli opened this issue Jan 19, 2022 · 1 comment
Closed

Broken code coverage #828

fpoli opened this issue Jan 19, 2022 · 1 comment
Labels
pending-on-external Issues that we cannot resolve due to factors outside of our control (e.g. in rustc).

Comments

@fpoli
Copy link
Member

fpoli commented Jan 19, 2022 •
edited
Loading

Since #816, it seems that the measured code coverage of the test suite dropped from 76% to 28%. Somehow, prusti-viper and other important modules no longer show up in the report. This looks like a bug in the way we measure code coverage, in codecov.io, or in rustc.
@fpoli fpoli added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers pending-on-external Issues that we cannot resolve due to factors outside of our control (e.g. in rustc). and removed bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jan 19, 2022
@fpoli
Copy link
Member Author

fpoli commented Jan 19, 2022

This is probably the reason: rust-lang/rust#93054

@fpoli fpoli closed this as completed Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pending-on-external Issues that we cannot resolve due to factors outside of our control (e.g. in rustc).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fpoli