Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better aggregate controls #47

Closed
kirangadhave opened this issue Jun 21, 2023 · 4 comments
Closed

Add better aggregate controls #47

kirangadhave opened this issue Jun 21, 2023 · 4 comments
Assignees

Comments

@kirangadhave
Copy link
Member

kirangadhave commented Jun 21, 2023

We have a single Aggregate button which aggregates with the mean operation. It would be useful to have multiple controls for options like: Aggregate Sum, Aggregate Mean, Aggregate Group-By.

Aggregate Group-by creates the group-by object without any operation specified. In terms of visualization, we can show this by a convex hull (maybe?) instead of adding the aggregate point and removing the original points.

@kirangadhave kirangadhave changed the title Add "Aggregate Sum, Aggregate Mean, Aggregate Group-By buttons" Add better aggregate controls Jun 21, 2023
@kirangadhave
Copy link
Member Author

@alexsb I don't recall what the Aggregate Group-by does. Was it to allow selecting any aggregation operation?

@alexsb
Copy link
Member

alexsb commented Jun 21, 2023

It creates a group-by object instead of a dataframe, where the aggregate function can later be specified in code.

@kirangadhave
Copy link
Member Author

ah that makes sense.

@kirangadhave
Copy link
Member Author

To check:

  • add warning when aggregating with sum operation, if the field is not aggregate encoding

@kirangadhave kirangadhave self-assigned this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants