Allow multiple returned content types from one renderer #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradykieffer
force-pushed
the
brady/dynamic-media-type
branch
2 times, most recently
from
27e0f82
to
6d7d0a4
Compare
|
The missing pagination coverage is in: #1276 which I don't want to blindly copy-paste. However, my patch is covered fully now. Would be great to know if this is a feasible change, or what else would be needed. |
bradykieffer
force-pushed
the
brady/dynamic-media-type
branch
from
6d7d0a4
to
bdf01e2
Compare
Switch these off of the accept header within a request. This allows users to dynamically render a response based on the clients passed value, with a fallback to whatever media type is specified by default. The list is implicitly ordered by priority. I don't love that it's a nested loop, however, I think that it should be fine, for relatively few content types.
bradykieffer
force-pushed
the
brady/dynamic-media-type
branch
from
bdf01e2
to
799e501
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I love the project - a request we commonly see from users is the ability to obtain our data in separate formats. I've seen my fair share of endpoints that are essentially identical, where one spits out JSON and another spits out CSV. Maintaining these forked views is pretty annoying, so I figured enabling APIs to render responses based on the
Acceptheader would be a cool feature 😄I picked
Dynamicin about 30 seconds, so very open to renaming this. But would love to get this type of functionality in.