[Enhancement] : Add middleware for PATCH | PUT file upload
#719
Conversation
This reverts commit 9159491, reversing changes made to eed29fd. [`Enhancement`] : Add middleware Update middlewares.py Update middlewares.py Fix mypy Update test_middleware.py Run isort and fix async codes Fox Sync Codes Sync Middleware test complete add Create test_middleware.py Update middlewares.py Delete foo.txt Update test_middleware.py Update test_middleware.py Update test_middleware.py [Docs] : Run isort Update install_env.sh Update middlewares.py Update middlewares.py Update test_middleware.py
|
Hi @vitalik , we have run into an error. Async middlewares are only supported in 3.1 and upwards. Do you want me to drop the async middleware to keep compatibility or do you want me to bump django version to 3.1 and upwards. the problematic import is This class isn't available in django 3.1 and earlier. My opinion on this matter is that make a repository that will have this specific code and then link to the docs about this middleware and when we finally drop django 3.1 support we will merge this into main branch Or maybe look into core and see how we can patch it without using a middleware. ( like how |
|
Django 2 is EOL. In my opinion we should target 3.2 and upwards |
Update pyproject.toml remove old django Update test_middleware.py Remove run `black` Run `isort` Update pyproject.toml Update test_full.yml
Ignore The coverage of this line because it works in the file
|
Hey @vitalik , I have skipped coverage on middleware as the middleware works as expected :) |
|
merge this after #720 |
|
Hi @vitalik, Due to the lack of input on this Pull Request i have made Feel free to open this pull request again to continue the progress here. Thank you again for creating |
Closes #716