Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite SSR doesn't support "Arbitrary Module Namespace Identifiers" #17426

Closed
7 tasks done
hi-ogawa opened this issue Jun 9, 2024 · 0 comments · Fixed by #17446
Closed
7 tasks done

Vite SSR doesn't support "Arbitrary Module Namespace Identifiers" #17426

hi-ogawa opened this issue Jun 9, 2024 · 0 comments · Fixed by #17446
Labels
feat: ssr p3-minor-bug An edge case that only affects very specific usage (priority)

Comments

@hi-ogawa
Copy link
Collaborator

hi-ogawa commented Jun 9, 2024

Describe the bug

We had a report on Vitest vitest-dev/vitest#5851 and it looks like the issue is in Vite's SSR transform.

// file-2.js
const something = "Something";

export { something as "arbitrary string" };

export { something as normalIdentifier };
# [OK] import from node
$ node repro-node.js
[Module: null prototype] {
  'arbitrary string': 'Something',
  normalIdentifier: 'Something'
}

# [NOT OK] import from Vite ssrLoadModule
$ node repro-vite.js
{
  undefined: [Getter],
  normalIdentifier: [Getter],
  [Symbol(Symbol.toStringTag)]: 'Module'
}

# [OK] import from Vite client
$ pnpm dev

links

Reproduction

https://github.com/hi-ogawa/reproductions/tree/main/vite-ssr-arbitrary-module-namespace-identifier

Steps to reproduce

Also on stackblitz https://stackblitz.com/github/hi-ogawa/reproductions/tree/main/vite-ssr-arbitrary-module-namespace-identifier

System Info

(stackblitz)

  System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    vite: ^5.2.13 => 5.2.13

Used Package Manager

pnpm

Logs

No response

Validations

@sheremet-va sheremet-va added p3-minor-bug An edge case that only affects very specific usage (priority) feat: ssr and removed pending triage labels Jun 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feat: ssr p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants