fix!: remove deprecated node loader (#4371)

vitest-dev · Oct 25, 2023 · 29299f3 · 29299f3
1 parent 9527e65
commit 29299f3
Show file tree

Hide file tree

Showing 11 changed files with 460 additions and 846 deletions.
diff --git a/docs/config/index.md b/docs/config/index.md
@@ -192,7 +192,7 @@ Directory to save cache files.
 
 ### deps
 
-- **Type:** `{ optimizer?, registerNodeLoader?, ... }`
+- **Type:** `{ optimizer?, ... }`
 
 Handling for dependencies resolution.
 
@@ -278,15 +278,6 @@ By default, files inside `node_modules` are externalized and not transformed, un
 At the moment, this option only works with [`vmThreads`](#vmthreads) pool.
 :::
 
-#### deps.registerNodeLoader<NonProjectOption />
-
-- **Type:** `boolean`
-- **Default:** `false`
-
-Use [experimental Node loader](https://nodejs.org/api/esm.html#loaders) to resolve imports inside externalized files, using Vite resolve algorithm.
-
-If disabled, your `alias` and `<plugin>.resolveId` won't affect imports inside externalized packages (by default, `node_modules`).
-
 #### deps.interopDefault
 
 - **Type:** `boolean`

diff --git a/examples/solid/package.json b/examples/solid/package.json
@@ -6,14 +6,14 @@
     "coverage": "vitest --coverage"
   },
   "dependencies": {
-    "solid-js": "^1.4.3"
+    "solid-js": "^1.8.3"
   },
   "devDependencies": {
+    "@solidjs/testing-library": "^0.8.4",
     "@testing-library/jest-dom": "^5.16.4",
     "jsdom": "latest",
-    "solid-testing-library": "^0.5.0",
     "vite": "latest",
-    "vite-plugin-solid": "^2.5.0",
+    "vite-plugin-solid": "^2.7.2",
     "vitest": "latest"
   }
 }
diff --git a/examples/solid/test/Hello.test.jsx b/examples/solid/test/Hello.test.jsx
@@ -1,5 +1,5 @@
 import { describe, expect, test } from 'vitest'
-import { fireEvent, render } from 'solid-testing-library'
+import { fireEvent, render } from '@solidjs/testing-library'
 import { Hello } from '../components/Hello'
 
 describe('<Hello />', () => {

diff --git a/examples/solid/vite.config.mjs b/examples/solid/vite.config.mjs
@@ -13,6 +13,13 @@ export default defineConfig({
         isolate: false,
       },
     },
+    deps: {
+      optimizer: {
+        web: {
+          exclude: ['solid-js'],
+        },
+      },
+    },
   },
   plugins: [solid()],
   resolve: {

diff --git a/packages/vitest/rollup.config.js b/packages/vitest/rollup.config.js
@@ -26,7 +26,6 @@ const entries = [
   'src/runtime/worker.ts',
   'src/runtime/vm.ts',
   'src/runtime/child.ts',
-  'src/runtime/loader.ts',
   'src/runtime/entry.ts',
   'src/runtime/entry-vm.ts',
   'src/integrations/spy.ts',

diff --git a/packages/vitest/src/node/config.ts b/packages/vitest/src/node/config.ts
@@ -198,16 +198,6 @@ export function resolveConfig(
       ?? resolve(resolved.root, resolved.runner)
   }
 
-  if (resolved.deps.registerNodeLoader) {
-    const transformMode = resolved.environment === 'happy-dom' || resolved.environment === 'jsdom' ? 'web' : 'ssr'
-    console.warn(
-      c.yellow(
-      `${c.inverse(c.yellow(' Vitest '))} "deps.registerNodeLoader" is deprecated.`
-      + `If you rely on aliases inside external packages, use "deps.optimizer.${transformMode}.include" instead.`,
-      ),
-    )
-  }
-
   resolved.testNamePattern = resolved.testNamePattern
     ? resolved.testNamePattern instanceof RegExp
       ? resolved.testNamePattern

diff --git a/packages/vitest/src/node/pool.ts b/packages/vitest/src/node/pool.ts
@@ -1,7 +1,4 @@
-import { pathToFileURL } from 'node:url'
 import mm from 'micromatch'
-import { resolve } from 'pathe'
-import { distDir, rootDir } from '../paths'
 import type { Pool } from '../types'
 import type { Vitest } from './core'
 import { createChildProcessPool } from './pools/child'
@@ -27,9 +24,6 @@ export interface PoolProcessOptions {
   env: Record<string, string>
 }
 
-const loaderPath = pathToFileURL(resolve(distDir, './loader.js')).href
-const suppressLoaderWarningsPath = resolve(rootDir, './suppress-warnings.cjs')
-
 export function createPool(ctx: Vitest): ProcessPool {
   const pools: Record<Pool, ProcessPool | null> = {
     forks: null,
@@ -74,19 +68,10 @@ export function createPool(ctx: Vitest): ProcessPool {
 
     const options: PoolProcessOptions = {
       ...ctx.projectFiles,
-      execArgv: ctx.config.deps.registerNodeLoader
-        ? [
-            ...execArgv,
-            '--require',
-            suppressLoaderWarningsPath,
-            '--experimental-loader',
-            loaderPath,
-            ...conditions,
-          ]
-        : [
-            ...execArgv,
-            ...conditions,
-          ],
+      execArgv: [
+        ...execArgv,
+        ...conditions,
+      ],
       env: {
         TEST: 'true',
         VITEST: 'true',

diff --git a/packages/vitest/src/runtime/loader.ts b/packages/vitest/src/runtime/loader.ts
diff --git a/packages/vitest/src/types/config.ts b/packages/vitest/src/types/config.ts
@@ -181,13 +181,6 @@ interface DepsOptions {
    */
   fallbackCJS?: boolean
 
-  /**
-   * Use experimental Node loader to resolve imports inside node_modules using Vite resolve algorithm.
-   * @default false
-   * @deprecated If you rely on aliases inside external packages, use `deps.optimizer.{web,ssr}.include` instead.
-   */
-  registerNodeLoader?: boolean
-
   /**
    * A list of directories relative to the config file that should be treated as module directories.
    *
@@ -805,7 +798,7 @@ export type ProjectConfig = Omit<
   | 'coverage'
 > & {
   sequencer?: Omit<SequenceOptions, 'sequencer' | 'seed'>
-  deps?: Omit<DepsOptions, 'registerNodeLoader' | 'moduleDirectories'>
+  deps?: Omit<DepsOptions, 'moduleDirectories'>
 }
 
 export type RuntimeConfig = Pick<