Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of a TLS secret with a cert signed by an external CA for the concierge impersonation proxy server cert #1397

Closed
nickperry opened this issue Feb 1, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request estimate/XS Estimated effort/complexity/risk is very small state/accepted All done!

Comments

@nickperry
Copy link

Is your feature request related to a problem? Please describe.

Currently, if a cluster gets rebuilt or pinniped concierge namespace removed, once concierge is redeployed we have to retrieve the new pinniped-concierge-impersonation-proxy-ca-certificate and update the CA data in the kubeconfig we store in git and on our SSH jump hosts. Until this happens we have disruption to our enigneers' ability to work.

We want instead to be able to configure pinniped to use an alternative secret to pinniped-concierge-impersonation-proxy-tls-serving-certificate for serving the impersonation proxy. We can configure certmanager to provide this secret, using our external CA. Because the external CA is stable, our skeleton pinniped kubeconfigs which we distribute to users can also remain stable. This will reduce disruption to our engineers and increase user satisfaction.

Describe the solution you'd like

I am happy for pinniped to use its own CA for everything else, but for serving the impersonation proxy, I want pinniped to have the option to use a custom TLS secret with a key and external CA signed cert.

Describe alternatives you've considered

Some sort of CI job to retrieve the new pinniped-concierge-impersonation-proxy-ca-certificate from a cluster and update it automatically in git. This is clunky though and we then still need to get it from git to our engineer userbase.

@pinniped-ci-bot pinniped-ci-bot added enhancement New feature or request priority/undecided Not yet prioritized labels Feb 9, 2023
@voor
Copy link
Member

voor commented Jun 2, 2023

This issue might be related to #1104

Would that capability also solve this problem?

@pinniped-ci-bot pinniped-ci-bot added the estimate/XS Estimated effort/complexity/risk is very small label Jul 20, 2023
@pinniped-ci-bot pinniped-ci-bot added priority/backlog Prioritized for an upcoming iteration state/started Someone is working on it currently and removed priority/undecided Not yet prioritized labels Jul 20, 2023
@pinniped-ci-bot pinniped-ci-bot added state/finished Code finished but not yet delivered and removed state/started Someone is working on it currently labels Jul 26, 2023
@pinniped-ci-bot pinniped-ci-bot added state/delivered Ready for manual acceptance review and removed state/finished Code finished but not yet delivered labels Aug 10, 2023
@pinniped-ci-bot pinniped-ci-bot added state/accepted All done! and removed priority/backlog Prioritized for an upcoming iteration state/delivered Ready for manual acceptance review labels Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request estimate/XS Estimated effort/complexity/risk is very small state/accepted All done!
Projects
None yet
Development

No branches or pull requests

5 participants