-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wildcards don't work for namespaces #1874
Comments
Around https://github.com/heptio/velero/blob/master/pkg/backup/resource_backupper.go#L164, we're assuming that the namespace includes/excludes are "resolved" namespaces, which obviously doesn't hold with wildcards. We'd need to add some logic here to first get a full list of namespaces from the cluster, then check each one to see if it should be included, and then proceed with backing up those namespaces. |
Here is a note from @sseago:
Source: #4250 (review) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Un-stale please. |
Yes, please, unstale/fix |
Are there any plans for fixing this? |
Does anyone know if this issue has been resolved or are there plans to fix? |
Also experiencing the same error. is there a fix? |
Just ran into this. Any update on the potential of this work being completed? |
@davidblum Current status is that it's not being worked on. Velero 1.13 scope is largely defined at this point, but if there is enough interest, it could possibly be considered for Velero 1.14. |
+1 for this, in addition it would be great to have a |
I am interested in this feature too! It would be very useful in the scale case. Since #4250 has allowed specifying wildcards in the included namespaces, it's kind of werid that it's permitted now but nothing gets backup except for namespaces themselves. |
I had the impression that velero handles namespace quite differently comparing to regular resources, so the solution may not be as straightforward as we thought. @blackpiglet |
It's not easy to implement this request. Second, if we allow mixing the regex and regular namespace in Third, if we support regex in both I'm not against implementing it, but it needs more effort than it looks. We should ensure there is no break change and it doesn't impact the following resource collecting. |
Let me keep it in ice-box |
What steps did you take and what happened:
[A clear and concise description of what the bug is, and what commands you ran.)
Tried to create a backup for all namespaces that matches
*-helm
regexvelero backup create wp-airflow-helm --include-namespaces "*-helm"
What did you expect to happen:
Backup created for just that specific namespaces that matched regex
The output of the following commands will help us better understand what's going on:
(Pasting long output into a GitHub gist or other pastebin is fine.)
kubectl logs deployment/velero -n velero
velero backup describe <backupname>
orkubectl get backup/<backupname> -n velero -o yaml
:velero backup logs <backupname>
:Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:
velero version
): v1.1.0kubectl version
):/etc/os-release
): MacOSThe text was updated successfully, but these errors were encountered: