Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] CSI snapshot integration #2066

Open
skriss opened this issue Nov 14, 2019 · 9 comments
Open

[Epic] CSI snapshot integration #2066

skriss opened this issue Nov 14, 2019 · 9 comments
Assignees
Labels
Area/CSI Related to Container Storage Interface support Enhancement/User End-User Enhancement to Velero Epic kind/requirement Reviewed Q2 2021

Comments

@skriss
Copy link
Contributor

skriss commented Nov 14, 2019

No description provided.

@skriss skriss added Enhancement/User End-User Enhancement to Velero P1 - Important labels Nov 14, 2019
@skriss skriss added this to the v1.3 milestone Nov 14, 2019
@skriss skriss changed the title CSI snapshot integration [Epic] CSI snapshot integration Nov 14, 2019
@skriss
Copy link
Contributor Author

skriss commented Nov 14, 2019

we've got 3 issues under this epic, but we need to break this down further. To do as a team once we finalize design.

@dns2utf8
Copy link
Contributor

dns2utf8 commented Dec 3, 2019

What is the status of this? Is it possible to backup the contents of a pvc with version 1.2.0?

@skriss
Copy link
Contributor Author

skriss commented Dec 3, 2019

@dns2utf8 in v1.2, you can back up non-CSI volumes (e.g. EBS, Google PD, Azure Disk) using snapshots, or any other type of volume using restic (https://velero.io/docs/v1.2.0/restic/).

This issue covers integrating with the new CSI snapshot API, to be able to take snapshots of CSI-provisioned volumes.

@dns2utf8
Copy link
Contributor

dns2utf8 commented Dec 4, 2019

Do I understand correctly that this means CSI volumes are not snapshoted as of today?
I would like to backup the PVs of a MariaDB and a PostgreSQL.

@skriss
Copy link
Contributor Author

skriss commented Dec 4, 2019

@dns2utf8 that is correct. As of today, Velero can snapshot non-CSI volumes, or use restic to back up CSI volumes.

@dns2utf8
Copy link
Contributor

dns2utf8 commented Dec 6, 2019

Thank you for your replies. I had some initial success with restic.
However, now the contents of the PV don't get into the s3 bucket anymore and the pods are stuck at the "Terminating" state.
I searched the web for a solution, is the MountPropagation still needed with the securityContext: privileged: true?
My test-setup is in this repo: https://gitlab.com/dns2utf8/multi_file_writer

@skriss skriss added the Area/CSI Related to Container Storage Interface support label Jan 10, 2020
@nrb
Copy link
Contributor

nrb commented Jan 22, 2020

Currently waiting on upstream providers to add v2.0.0 controller/v1beta1 CRD support to their drivers. I've logged an issue on the Amazon driver to start.

While we could proceed with the v1alpha1 code, I'd prefer to keep moving forward and help update drivers rather than move backward and end up updating a lot of code later.

@ashish-amarnath
Copy link
Member

This is the issue with the GCP driver: kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#457

@skriss skriss modified the milestones: v1.3, v1.4 Feb 4, 2020
@skriss skriss removed this from the v1.4 milestone Apr 30, 2020
@ashish-amarnath ashish-amarnath added this to the v1.5 milestone Jun 1, 2020
@ashish-amarnath
Copy link
Member

There are 3 more issues pending in this epic. https://github.com/vmware-tanzu/velero/labels/CSI
Which are not going to make it for 1.5.
Punting the remaining issues to 1.6.

@dsu-igeek dsu-igeek modified the milestones: v1.7.0, v1.8.0 Jul 30, 2021
@reasonerjt reasonerjt added kind/requirement Reviewed Q2 2021 Area/CSI Related to Container Storage Interface support Epic Enhancement/User End-User Enhancement to Velero and removed Enhancement/User End-User Enhancement to Velero Epic Area/CSI Related to Container Storage Interface support Reviewed Q2 2021 labels May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/CSI Related to Container Storage Interface support Enhancement/User End-User Enhancement to Velero Epic kind/requirement Reviewed Q2 2021
Projects
None yet
Development

No branches or pull requests

7 participants