Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number count of errors in velero restore get is incorrect #7563

Closed
qpdpQ opened this issue Mar 25, 2024 · 4 comments
Closed

Number count of errors in velero restore get is incorrect #7563

qpdpQ opened this issue Mar 25, 2024 · 4 comments
Assignees
Milestone

Comments

@qpdpQ
Copy link

qpdpQ commented Mar 25, 2024

What steps did you take and what happened:

When I restore resources, data is not restored and I can see there is some error message in velero pod:

time="2024-03-15T09:43:57Z" level=error msg="Error executing hook" error="command terminated with exit code 1" hookPhase=post hookSource=annotation hookType=exec logSource="/remote-source/velero/app/internal/hook/wait_exec_hook_handler.go:173" pod=bawent/mongodb-backup-84bc8b8cb5-d9k2g restore=velero/restore-mongo-data

but the number count of ERRORS in velero restore get is 0

NAME                     BACKUP        STATUS      STARTED                         COMPLETED                       ERRORS   WARNINGS   CREATED                         SELECTOR
restore-mongo-data       backup-2302   Completed   2024-03-15 09:42:05 +0000 UTC   2024-03-15 09:43:57 +0000 UTC   0        0          2024-03-15 09:42:05 +0000 UTC   foundationservices.cloudpak.ibm.com=mongo-data

What did you expect to happen:
The velero restore get should show the number of errors correctly

The following information will help us better understand what's going on:

bundle-2024-03-25-11-24-39.tar.gz

Environment:

  • Velero version (use velero version):
# velero version
Client:
        Version: v1.12.3
        Git commit: 684f71306e9c2fda204a16cb012dc209523cfae1
Server:
        Version: v1.9.5-OADP
  • Velero features (use velero client config get features):
# velero client config get features
features: <NOT SET>
  • Kubernetes version (use kubectl version):
Client Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.2", GitCommit:"846602e50eb29ecdc7441ebed2fc846048959eaa", GitTreeState:"clean", BuildDate:"2023-03-08T15:10:20Z", GoVersion:"go1.19.4", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.16+6df2177", GitCommit:"f5b7c3e8faedd51935d77828a5fc72c7540236f4", GitTreeState:"clean", BuildDate:"2024-01-18T12:53:29Z", GoVersion:"go1.19.13 X:strictfipsruntime", Compiler:"gc", Platform:"linux/amd64"}
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
Openshift Cloud Platform
Client Version: 4.12.8
Kustomize Version: v4.5.7
Server Version: 4.12.50
Kubernetes Version: v1.25.16+6df2177
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "I would like to see this bug fixed as soon as possible"
  • 👎 for "There are more important bugs to focus on right now"
@allenxu404
Copy link
Contributor

Thanks for pointing it out.

This issue will be fixed with this PR: #7619 merged.

@qpdpQ
Copy link
Author

qpdpQ commented Apr 10, 2024

Hi @allenxu404 thanks for fixing! Do you know this fix will be included in which version?

@allenxu404
Copy link
Contributor

The fix will be included in v1.14

@reasonerjt
Copy link
Contributor

Closing as fixed.

@reasonerjt reasonerjt added this to the v1.14 milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants