Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more enable switch in predicate plugin. #2748

Closed
jiangkaihua opened this issue Mar 23, 2023 · 3 comments · Fixed by #2750
Closed

Add more enable switch in predicate plugin. #2748

jiangkaihua opened this issue Mar 23, 2023 · 3 comments · Fixed by #2750
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@jiangkaihua
Copy link
Contributor

What would you like to be added:

In volcano, all filter functions of origin Kubernetes was integrated in predicate plugin. So we could not disable some of the filter functions like NodePort meanwhile enable the other functions like NodeAffinity. So we need more enable arguments in predicate plugin to switch these filters.

The enable arguments could be like:

actions: "reclaim, allocate, backfill, preempt"
tiers:
- plugins:
  - name: priority
  - name: gang
  - name: conformance
- plugins:
  - name: drf
  - name: predicates
    arguments:
      predicate.NodeAffinityEnable: true
      predicate.NodePortsEnable: true
      predicate.TaintTolerationEnable: true
      predicate.podAffinityEnable: true
      predicate.NodeVolumeLimitsEnable: true
      predicate.VolumeZoneEnable: true
      predicate.PodTopologySpreadEnable: true
      predicate.GPUSharingEnable: true
      predicate.GPUNumberEnable: true
      predicate.CacheEnable: true
      predicate.ProportionalEnable: true
      predicate.resources: nvidia.com/gpu
      predicate.resources.nvidia.com/gpu.cpu: 4
      predicate.resources.nvidia.com/gpu.memory: 8
  - name: proportion
  - name: nodeorder

Why is this needed:

@jiangkaihua jiangkaihua added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 23, 2023
@wangyang0616
Copy link
Member

/assign @jiangkaihua

@lowang-bh
Copy link
Member

Configuring those plugin's weigh to 0 can work for it.

@jiangkaihua
Copy link
Contributor Author

Configuring those plugin's weigh to 0 can work for it.

As filter & prefilter plugins, they could only return true/false to permit a node to be candidate for a pod or not, so we may not set plugin weight on these plugins.

@william-wang william-wang added this to the v1.8 milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants